Skip to content

Refactor of stream_all_messages, fix flaky stream tests #1870

Refactor of stream_all_messages, fix flaky stream tests

Refactor of stream_all_messages, fix flaky stream tests #1870

Triggered via pull request June 27, 2024 21:09
Status Failure
Total duration 5m 8s
Artifacts

lint.yaml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 12 warnings
lint
Process completed with exit code 1.
unused `std::result::Result` that must be used: xmtp_mls/src/subscriptions.rs#L471
warning: unused `std::result::Result` that must be used --> xmtp_mls/src/subscriptions.rs:471:9 | 471 | handle.await.unwrap(); | ^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 471 | let _ = handle.await.unwrap(); | +++++++
unused import: `tracing_test::traced_test`: xmtp_mls/src/lib.rs#L64
warning: unused import: `tracing_test::traced_test` --> xmtp_mls/src/lib.rs:64:9 | 64 | use tracing_test::traced_test; | ^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `log::LevelFilter`: xmtp_mls/src/lib.rs#L63
warning: unused import: `log::LevelFilter` --> xmtp_mls/src/lib.rs:63:9 | 63 | use log::LevelFilter; | ^^^^^^^^^^^^^^^^
unused import: `UnboundedSender`: xmtp_mls/src/subscriptions.rs#L10
warning: unused import: `UnboundedSender` --> xmtp_mls/src/subscriptions.rs:10:24 | 10 | sync::mpsc::{self, UnboundedSender}, | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `UnboundedSender`: xmtp_mls/src/subscriptions.rs#L10
warning: unused import: `UnboundedSender` --> xmtp_mls/src/subscriptions.rs:10:24 | 10 | sync::mpsc::{self, UnboundedSender}, | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
very complex type used. Consider factoring parts into `type` definitions: src/mls.rs#L962
warning: very complex type used. Consider factoring parts into `type` definitions --> src/mls.rs:962:13 | 962 | handle: Arc<Mutex<Option<JoinHandle<Result<(), ClientError>>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: src/mls.rs#L962
warning: very complex type used. Consider factoring parts into `type` definitions --> src/mls.rs:962:13 | 962 | handle: Arc<Mutex<Option<JoinHandle<Result<(), ClientError>>>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
unused import: `crate::logger::init_logger`: src/mls.rs#L2
warning: unused import: `crate::logger::init_logger` --> src/mls.rs:2:5 | 2 | use crate::logger::init_logger; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `crate::logger::init_logger`: src/mls.rs#L2
warning: unused import: `crate::logger::init_logger` --> src/mls.rs:2:5 | 2 | use crate::logger::init_logger; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `UnboundedSender`: /home/runner/work/libxmtp/libxmtp/xmtp_mls/src/subscriptions.rs#L10
warning: unused import: `UnboundedSender` --> /home/runner/work/libxmtp/libxmtp/xmtp_mls/src/subscriptions.rs:10:24 | 10 | sync::mpsc::{self, UnboundedSender}, | ^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/