Skip to content

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #901

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/…

Merge branch '04-07-identityupdate_serialization' of github.com:xmtp/… #901

Triggered via push April 7, 2024 22:36
Status Success
Total duration 5m 16s
Artifacts

ci-image.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
unneeded `return` statement: xmtp_id/src/associations/serialization.rs#L180
warning: unneeded `return` statement --> xmtp_id/src/associations/serialization.rs:180:17 | 180 | None => return Err(DeserializationError::MissingSignature), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 180 | None => Err(DeserializationError::MissingSignature), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unneeded `return` statement: xmtp_id/src/associations/serialization.rs#L160
warning: unneeded `return` statement --> xmtp_id/src/associations/serialization.rs:160:17 | 160 | None => return Err(DeserializationError::MissingMemberIdentifier), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 160 | None => Err(DeserializationError::MissingMemberIdentifier), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
casting to the same type is unnecessary (`u64` -> `u64`): xmtp_id/src/associations/serialization.rs#L128
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> xmtp_id/src/associations/serialization.rs:128:28 | 128 | nonce: create_inbox_action.nonce as u64, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `create_inbox_action.nonce` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
writing `&Vec` instead of `&[_]` involves a new object where a slice will do: xmtp_id/src/associations/serialization.rs#L112
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> xmtp_id/src/associations/serialization.rs:112:14 | 112 | actions: &Vec<IdentityActionKindProto>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[IdentityActionKindProto]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default
casting to the same type is unnecessary (`u64` -> `u64`): xmtp_id/src/associations/serialization.rs#L75
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> xmtp_id/src/associations/serialization.rs:75:28 | 75 | nonce: create_inbox_action.nonce as u64, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `create_inbox_action.nonce` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: xmtp_id/src/associations/builder.rs#L310
warning: this expression creates a reference which is immediately dereferenced by the compiler --> xmtp_id/src/associations/builder.rs:310:22 | 310 | .get(&signer_identity) | ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: xmtp_id/src/associations/builder.rs#L293
warning: this expression creates a reference which is immediately dereferenced by the compiler --> xmtp_id/src/associations/builder.rs:293:22 | 293 | .get(&signer_identity) | ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: xmtp_id/src/associations/builder.rs#L276
warning: this expression creates a reference which is immediately dereferenced by the compiler --> xmtp_id/src/associations/builder.rs:276:22 | 276 | .get(&new_member_signer_identity) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `new_member_signer_identity` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: xmtp_id/src/associations/builder.rs#L271
warning: this expression creates a reference which is immediately dereferenced by the compiler --> xmtp_id/src/associations/builder.rs:271:22 | 271 | .get(&existing_member_signer_identity) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `existing_member_signer_identity` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: xmtp_id/src/associations/builder.rs#L250
warning: this expression creates a reference which is immediately dereferenced by the compiler --> xmtp_id/src/associations/builder.rs:250:22 | 250 | .get(&signer_identity) | ^^^^^^^^^^^^^^^^ help: change this to: `signer_identity` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
redundant closure: xmtp_mls/src/groups/subscriptions.rs#L89
warning: redundant closure --> xmtp_mls/src/groups/subscriptions.rs:89:13 | 89 | move |message| callback(message), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `callback` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default
unnecessary map of the identity function: xmtp_mls/src/groups/members.rs#L42
warning: unnecessary map of the identity function --> xmtp_mls/src/groups/members.rs:42:22 | 42 | .ok() | ______________________^ 43 | | .map(|basic_credential| (basic_credential))?; | |___________________________________________________________^ help: remove the call to `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity = note: `#[warn(clippy::map_identity)]` on by default
returning the result of a `let` binding from a block: xmtp_api_grpc/src/auth_token.rs#L59
warning: returning the result of a `let` binding from a block --> xmtp_api_grpc/src/auth_token.rs:59:9 | 58 | let token_base64 = base64::engine::general_purpose::STANDARD.encode(&token_bytes); | ---------------------------------------------------------------------------------- unnecessary `let` binding 59 | token_base64 | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 58 ~ 59 ~ base64::engine::general_purpose::STANDARD.encode(&token_bytes) |
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L2424
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:2424:91 | 2424 | struct_ser.serialize_field("content", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L391
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:391:115 | 391 | struct_ser.serialize_field("unsignedLegacyCreateIdentityKey", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs#L387
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.mls.message_contents.serde.rs:387:99 | 387 | struct_ser.serialize_field("installationKey", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L2951
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:2951:86 | 2951 | struct_ser.serialize_field("senderHmac", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.message_contents.serde.rs#L1334
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.message_contents.serde.rs:1334:86 | 1334 | struct_ser.serialize_field("v1", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
the borrowed expression implements the required traits: xmtp_proto/src/gen/xmtp.identity.associations.serde.rs#L916
warning: the borrowed expression implements the required traits --> xmtp_proto/src/gen/xmtp.identity.associations.serde.rs:916:105 | 916 | struct_ser.serialize_field("installationPublicKey", pbjson::private::base64::encode(&v).as_str())?; | ^^ help: change this to: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
this function has too many arguments (8/7): src/mls.rs#L49
warning: this function has too many arguments (8/7) --> src/mls.rs:49:1 | 49 | / pub async fn create_client( 50 | | logger: Box<dyn FfiLogger>, 51 | | host: String, 52 | | is_secure: bool, ... | 57 | | legacy_signed_private_key_proto: Option<Vec<u8>>, 58 | | ) -> Result<Arc<FfiXmtpClient>, GenericError> { | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.