Check for id in stanza before using it #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was introduced in #90. The public npm registry doesn't have the latest version so don't think anyone really noticed it. Do you know when the version there will be updated? |
markstory
added a commit
that referenced
this pull request
Oct 2, 2015
Check for id in stanza before using it
|
I can aim to make a new package tonight. |
|
@markstory thanks! I can see it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have caught this earlier, but just a missing ?.
Not all stanzas have id set and this was actually causing serious problems: hubot stopped responding and I had to restart it.