Rmii example #89
Rmii example #89
Conversation
shuchitak
force-pushed
the
rmii_example
branch
5 times, most recently
from
b5dc6f7 to
5fb9844
Compare
shuchitak
force-pushed
the
rmii_example
branch
from
5fb9844 to
8ddef4e
Compare
There was a problem hiding this comment.
Not sure how useful this diagram is - would just remove it rather than updating it
There was a problem hiding this comment.
Yeah, I'll remove it for now.
There was a problem hiding this comment.
This is now wrong, but we know that. It's 4 threads and the names aren't good. Better maybe:
Rx packet, Tx packet, filter, server
There was a problem hiding this comment.
yes, this is still the standard MAC diagram. I'll remove it and add the updated block diagram in a separate documentation focussed PR.
| @@ -0,0 +1,21 @@ | |||
| # This file relates to internal XMOS infrastructure and should be ignored by external users | |||
There was a problem hiding this comment.
We should probably ask if this is a new app note. I expect we would need to put it in xmosnotes at some point
There was a problem hiding this comment.
But not a concern right now
There was a problem hiding this comment.
Yes, this has appnote level documentation. We'll move it to xmosnotes at some point.
There was a problem hiding this comment.
Actually, none of the images in the images/ directory make sense. I'll remove them all. We can add later
| #include "xk_eth_xu316_dual_100m/board.h" | ||
| #include "debug_print.h" | ||
|
|
||
| rmii_data_port_t p_eth_rxd = {{PHY_0_RXD_4B, USE_LOWER_2B}}; |
There was a problem hiding this comment.
These need to be USE_UPPER_2B
There was a problem hiding this comment.
Thanks. I'll fix this. What about rmii_data_port_t p_eth_txd = {{PHY_0_TXD_4B, USE_LOWER_2B}};? Is USE_LOWER_2B for PHY_0_TXD_4B ok?
There was a problem hiding this comment.
They are both HIGHER as the pinout somewhat reflects what is available on the QF60 even though it's TQ128. Probably should used the LOWER ones as that's a tougher case, but I recall there is a fair bit of margin in the ASM
| }; | ||
|
|
||
| [[combinable]] | ||
| void lan8710a_phy_driver(client interface smi_if smi, |
There was a problem hiding this comment.
This function can be deleted
There was a problem hiding this comment.
There are issues with the diagrams but we know that. With the FW changes I think we can merge this for now and update when we get info about the kit.
It might be worth being clear about which ethernet port is activated in the docs - but again this will be easier to define once we see physical HW.
shuchitak
force-pushed
the
rmii_example
branch
from
c559a53 to
b6384fb
Compare
No description provided.