Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manylinux CI workflow #334

Closed

Conversation

jonathangreen
Copy link
Contributor

@jimjag how do you feel about deleting the manylinux.yml workflow as well? The wheel build workflow does basically the same thing, and deleting it would get CI passing on this repo again.

@jimjag
Copy link
Collaborator

jimjag commented Nov 5, 2024

I'm hesitant to remove it since it provides insight into how things will work on AWS and various PaaS environments, such as Heroku. Let's see if we can clean it up 1st.

@jonathangreen
Copy link
Contributor Author

jonathangreen commented Nov 5, 2024

@jimjag can you clarify what this workflow is doing that should be tested that wheels.yml isn't already doing?

Both the workflows build a wheel using the manylinux containers. The wheels.yml workflow is more automated, and builds for more targets. So I don't see much value in this workflow.

@jonathangreen
Copy link
Contributor Author

I'll close this one then, since @jimjag isn't interested in it.

@jonathangreen jonathangreen deleted the delete-manylinux-ci branch November 10, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants