Add windows builds to cibuildwheel workflow #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/ci-build-wheel-windows
branch
from
c8c6542
to
c37bcb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mxamin this adds the windows jobs back into the cibuildwheel workflow, so you can see how they are failing. This is the same code as #294 with a couple lines added in this commit 412127b to enable the windows builds.
The blocker here for getting the windows builds to go green is that I don't know much about python builds on windows. I did take a quick look though the code in setup.py when I was doing the other CI updates, and it looks like the windows builds depend on some pre-build binaries from this repo: https://github.com/bgaifullin/libxml2-win-binaries. See setup.py#L216.
This seems very similar to what lxml is doing for its windows builds:
https://github.com/lxml/lxml/blob/a9f31d9ba0f6db7b0c6576b4b9014a4ea7649eca/buildlibxml.py#L29-L36
It seems like the repo with those binaries in it may need to be updated (and maybe moved into the xmlsec github org?) to get the windows builds working.