Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies and add dart_code_linter #212

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

fedecor9
Copy link
Contributor

@fedecor9 fedecor9 commented Jun 3, 2024

⭐ Feature

✏️ Description:

Updated package dependencies and flutter version.
Fixed deprecated classes from latest flutter version and added dart_code_linter as code analyzer

@fedecor9 fedecor9 requested a review from mirland June 3, 2024 15:58
@fedecor9 fedecor9 changed the title Feat: update dependencies and add dart_code_linter feat: update dependencies and add dart_code_linter Jun 3, 2024
Copy link
Member

@f7deleon f7deleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 weird that now we have to use double quotes for yaml

Comment on lines -17 to -18
- avoid_returning_null
- avoid_returning_null_for_future
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we want this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This rule is removed in Dart 3.3.0; it is no longer functional.

Both rules say this in the docs
https://dart.dev/tools/linter-rules/avoid_returning_null

Comment on lines -91 to +90
onBackground: const Color(0xffadadad),
background: const Color(0xfff7fafd),
onSurface: const Color(0xffadadad),
surface: const Color(0xfff7fafd),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to delete background and onBackground?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onBackground and background is deprecated in the latest version
https://api.flutter.dev/flutter/material/ColorScheme/onBackground.html

@fedecor9 fedecor9 merged commit 94e3b7b into main Jun 3, 2024
2 checks passed
@fedecor9 fedecor9 deleted the feat/update-dependencies branch June 3, 2024 21:53
@fedecor9 fedecor9 linked an issue Jul 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze dart code metrics
3 participants