feat: add theme extensions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedecor9
requested changes
Dec 20, 2023
mirland
reviewed
Dec 22, 2023
mirland
approved these changes
Dec 28, 2023
fedecor9
approved these changes
Dec 28, 2023
| : _generateMaterialColor(); | ||
|
|
||
| MaterialColor _generateMaterialColor() => MaterialColor(value, { | ||
| 50: _tintColor(0.9), |
There was a problem hiding this comment.
shouldn't this be shade instead of tint? whats the difference?
There was a problem hiding this comment.
The difference it is the way of calculate tint and shade
| final Color? warning; | ||
| final Color? danger; | ||
|
|
||
| static CustomColors getCustomColors() => const CustomColors( |
There was a problem hiding this comment.
Is this necessary, isn't it accessible by Theme.of(context).extension<MyColors>()!
There was a problem hiding this comment.
Would we like to access the colors that way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐ Feature
✏️ Description:
Add theme extensions of colors, typography and dimensions.