Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFML: Fix msvc runtime when using MTd without debug #6073

Merged
merged 1 commit into from
Dec 27, 2024
Merged

SFML: Fix msvc runtime when using MTd without debug #6073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/s/sfml/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,8 @@ package("sfml")
end
else
table.insert(configs, "-DBUILD_SHARED_LIBS=OFF")
if package:is_plat("windows") and package:has_runtime("MT", "MTd") then
table.insert(configs, "-DSFML_USE_STATIC_STD_LIBS=ON")
end
-- SFML overrides MSVC runtimes if set to ON, xmake already takes cares of setting it
table.insert(configs, "-DSFML_USE_STATIC_STD_LIBS=OFF")
end
table.insert(configs, "-DSFML_BUILD_AUDIO=" .. (package:config("audio") and "ON" or "OFF"))
table.insert(configs, "-DSFML_BUILD_GRAPHICS=" .. (package:config("graphics") and "ON" or "OFF"))
Expand Down
Loading