Support des shelly gen1. en triphasé #50
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposition de changement d'api shelly pour supporter les devices de premiere generation.
Normalement pas d'effet de bord pour le monophasé.
Changements:
Discussion
Testé uniquement avec shelly 3em. Je suis parti du principe que le 3em-pro était rétro-compatible avec l'api gen1., mais je n'ai pas de quoi tester.
Explication des changements
J'ai déporté le code de requête http de la fonction
shelly_get_data
versshelly_read_meter()
. Dans le cas du tri, les trois compteurs sont interrogés (et accumulés) successivement, sauf en cas d'erreur de lecture.J'ai également légèrement factorisé et nettoyé le code.