Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #329. After a basic inspection of the codebase, I find the current Acto does have some retry mechanisms. However, because of some
subprocess.run
for command execution have an argument ofcheck=True
, according to the document:If check is set to True and the command failed, a CalledProcessError will be raised and the following
returncode
logic becomes meaningless. So currently, I only correct somecheck
arguments to make the current retry mechanisms meaningful.Besides, I also mentioned that although
create_cluster
logic for all 3 tools(kind, minikube, k3s) will retry for 3 times before if fails, thedelete_cluster
logic will forever try to delete if the command fails:Is this an expected design? Do we need to change this into the same as create_cluster logic (retry for 3 times and fail)?