Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix statefulset test property_name error #327

Merged
merged 3 commits into from
Feb 24, 2024
Merged

Conversation

LouHaina
Copy link
Contributor

No description provided.

@tylergu
Copy link
Member

tylergu commented Feb 23, 2024

@LouHaina Thank you so much for the PR! Could you send me the test.log where the problem occured? Looking at the code, I realize there might be another problem in the Acto's code.

@tianyin
Copy link
Member

tianyin commented Feb 23, 2024

WoW! Thank you for the contribution @LouHaina !

@LouHaina
Copy link
Contributor Author

@LouHaina Thank you so much for the PR! Could you send me the test.log where the problem occured? Looking at the code, I realize there might be another problem in the Acto's code.

Sure. The test.log with schema type error: test.log

@@ -64,7 +64,7 @@ def replicas_tests(schema: IntegerSchema) -> list[TestCase]:
@test_generator(
property_name="statefulSetUpdateStrategy", priority=Priority.SEMANTIC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouHaina I realized that the root cause of this problem is the property_name arg. It should be "updateStrategy", corresponding to the https://kubernetes.io/docs/tutorials/stateful-application/basic-stateful-set/#updating-statefulsets

Since we had a wrong name, this test generator is mistakenly matched to a wrong field in tidb-operator.

Could you change the fix to change the property_name? With that fixed, the rest of the fix should not be needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the property_name to "updateStrategy" without the previously proposed fixes, and pushed the updates

@LouHaina LouHaina changed the title Fix statefulset test schema type error Fix statefulset test property_name error Feb 24, 2024
@tylergu tylergu merged commit 815da84 into xlab-uiuc:main Feb 24, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants