-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set 'fork' as the default process start method #272
Merged
ThrivikramanV
merged 1 commit into
xlab-uiuc:main
from
MarkintoshZ:fix-process-start-method
Nov 1, 2023
Merged
set 'fork' as the default process start method #272
ThrivikramanV
merged 1 commit into
xlab-uiuc:main
from
MarkintoshZ:fix-process-start-method
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Zhang <[email protected]>
@ThrivikramanV can you review this commit and merge it? |
Verified @MarkintoshZ's comments and code. Will run the e2e tests on the cloudlab systems and then merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Runner
class depends on 'fork' process start method but this is not the default of multiprocessing lib on Windows and MacOS. This PR ensures 'fork' is the default and it is makes Acto to be compatible with MacOS. In addition, setting the default set method is recommended according to the Python documentation.