Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge modes big refactor #592

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

wismill
Copy link
Member

@wismill wismill commented Jan 14, 2025

Follow-up of #568, with tests and fixes for all components.

Merge modes parameters are aggressively removed, so that:

  • Sections are always compiled in isolation
  • Merge mode for inclusion does not affect the included section until merging with either the previous section in the include statement or its parent.
  • … ?

See this comment from @mahkoh and the follow-up discussion.

TODO:

@wismill wismill added bug Indicates an unexpected problem or unintended behavior testing Indicates a need for improvements or additions to testing compile-keymap Indicates a need for improvements or additions to keymap compilation labels Jan 14, 2025
@wismill
Copy link
Member Author

wismill commented Jan 14, 2025

This can potentially break some advanced setups that rely on merge modes current propagation, so maybe it is safer to wait for next release while improving the tests.

@wismill wismill added this to the 1.9.0 milestone Jan 14, 2025
@wismill wismill force-pushed the merges-modes-big-refactor branch 3 times, most recently from e7253c6 to 6aecd1e Compare January 15, 2025 11:43
@wismill wismill force-pushed the merges-modes-big-refactor branch from 6aecd1e to 892a80a Compare January 15, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation testing Indicates a need for improvements or additions to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant