Support querying whether virtual modifiers are active (alternative 2) #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wismill
added
the
state
This was referenced Sep 23, 2024
Draft
wismill
force-pushed
the
modifiers/query-virtual-mods
branch
from
946ec04
to
06597bd
Compare
|
TODO: more tests, with all modifiers. We want this to be 100% reliable, with no breaking changes in the known and foreseen uses. |
Respect the claim that real modifiers names are built-in: - Add `XKB_MOD_NAME_MOD[1-5]` constants. - Replace modifiers names with their corresponding constants.
Changed the value of the following constant to match the actual name of their corresponding modifier: - `XKB_MOD_NAME_ALT` - `XKB_MOD_NAME_LOGO` - `XKB_MOD_NAME_NUM` Added support for the following modifiers: - `Meta` - `Super` (alternative constant) - `Hyper` - `LevelThree` - `LevelFive` - `ScrollLock`
Previously it was not possible to query the status of virtual modifiers with the following functions: - `xkb_state_mod_index_is_active` - `xkb_state_mod_indices_are_active` - `xkb_state_mod_name_is_active` - `xkb_state_mod_names_are_active` Note that it may *overmatch* if some modifier mappings overlap. For example, the default “us” PC layout maps both “Alt” and “Meta” to the real modifier “Mod1”; thus “Mod1”, “Alt” and “Meta” modifiers will return the same result with these functions.
wismill
force-pushed
the
modifiers/query-virtual-mods
branch
from
06597bd
to
700d0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller version of #353, which is also an alternative to #36.
This is necessary to implement fully #450.