Disable compiler warnings for known custom cfg values
#3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfgs that are not features or dependencies from Cargo.toml (so e.g. cfgs set by build.rs or external tools like cargo-fuzz) will cause compiler warnings starting with Rust 1.80.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3384 +/- ##
==========================================
+ Coverage 88.52% 88.72% +0.20%
==========================================
Files 89 89
Lines 28323 27753 -570
==========================================
- Hits 25074 24625 -449
+ Misses 3249 3128 -121 ☔ View full report in Codecov by Sentry. |
|
I think this looks fine, but I'm curious, is this not solvable in some way other than ignoring? For example, can we fix this in our build.rs? |
|
Yes that's possible too, but it looks like the [lints] entry is meant for cfgs that are statically known while the build.rs approach is more meant for dynamic addition of cfgs. At least it reads that way to me, but I really don't have a preference one way or the other |
lu-zero
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context.
TL;DR: Custom
cfgs are considered unexpected byrustc, so they will produce a warning (on 1.80+) unless they're added to a list of known custom cfgs.