Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nasm-rs to 0.3.0 #3383

Merged
merged 2 commits into from
May 25, 2024
Merged

Update nasm-rs to 0.3.0 #3383

merged 2 commits into from
May 25, 2024

Conversation

FreezyLemon
Copy link
Contributor

nasm-rs versions before 0.3 ignored the number of jobs set by cargo's job server. This means that even with cargo b -j1 or NUM_JOBS=1 cargo b, the rav1e build script uses 100% CPU.

@FreezyLemon
Copy link
Contributor Author

Also bumped jobserver while I'm at it. It has some small safety improvements.

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (3c3a26f) to head (2ffac65).
Report is 20 commits behind head on master.

Current head 2ffac65 differs from pull request most recent head 96beb31

Please upload reports for the commit 96beb31 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3383      +/-   ##
==========================================
+ Coverage   88.52%   88.72%   +0.20%     
==========================================
  Files          89       89              
  Lines       28323    27753     -570     
==========================================
- Hits        25074    24625     -449     
+ Misses       3249     3128     -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shssoichiro shssoichiro merged commit 0548232 into xiph:master May 25, 2024
25 checks passed
@FreezyLemon FreezyLemon deleted the update-nasm branch May 25, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants