Add new NASM pragma regarding macro parameter expansion #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.15.0 was released in June 2020. The current MSRV was released in June 2023, so this should not be a problem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3361 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 89 89
Lines 28323 28355 +32
==========================================
+ Hits 25074 25107 +33
+ Misses 3249 3248 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3330.
This raises the minimum NASM version to 2.15.0 which was released in June 2020. The minimum Rust version 1.70 was released in June 2023, so I don't think this is a problem.
I also spent a bit of time refactoring the build script slightly.