Integrate lossless forward transform intrinsics #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrbrain
force-pushed
the
lossless
branch
3 times, most recently
from
d162957
to
3f9e4b6
Compare
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
barrbrain
force-pushed
the
lossless
branch
5 times, most recently
from
5920bdc
to
05ec6f4
Compare
|
Why did we lose a test? that codepath isn't really exercised by our encode-decode tests? |
barrbrain
commented
Oct 20, 2023
| @@ -557,6 +557,7 @@ mod test { | |||
|
|
|||
| fn roundtrips<T: Pixel>() { | |||
| let combinations = [ | |||
| (TX_4X4, WHT_WHT, 0), | |||
There was a problem hiding this comment.
This replaces test_lossless_roundtrip() as it can now be expressed by test_roundtrip().
lu-zero
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxType::WHT_WHTand so unify theforward_transformandinverse_transform_addfunctions.fwht4through the existing forward transform code and gain anAVX2implementation.