Skip to content

Commit

Permalink
fix: Build musl librav1e deploy artifacts with crt static
Browse files Browse the repository at this point in the history
In order for the rav1e shared library to work on glibc systems, it needs
musl libc to be statically linked. Fixes #3242
  • Loading branch information
fdintino authored and barrbrain committed Nov 22, 2023
1 parent bc516fc commit 9b2f8ee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,9 @@ jobs:
# "cargo build" command to "cargo cinstall"
CROSS_BUILD_DOCKERFILE: ./cross/Dockerfile.libs
CARGO_TARGET_I686_UNKNOWN_LINUX_MUSL_RUSTFLAGS:
"-C target-feature=-crt-static"
"-C target-feature=+crt-static"
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_RUSTFLAGS:
"-C target-feature=-crt-static"
"-C target-feature=+crt-static"
run: |
cp ~/.cargo/bin/cargo-c* $(dirname $(rustup which cargo))
cross build --target ${{ matrix.target }} --profile release-strip
Expand All @@ -269,7 +269,7 @@ jobs:
if: matrix.build == 'sdk' && matrix.target == 'x86_64-unknown-linux-musl'
env:
RUSTFLAGS:
"-C target-feature=-crt-static -C target-cpu=${{ matrix.target_cpu }}"
"-C target-feature=+crt-static -C target-cpu=${{ matrix.target_cpu }}"
run: |
cargo cinstall --target ${{ matrix.target }} \
--prefix dist \
Expand Down

0 comments on commit 9b2f8ee

Please sign in to comment.