Skip to content

Commit

Permalink
1
Browse files Browse the repository at this point in the history
  • Loading branch information
xinyiZzz committed Jan 2, 2025
1 parent 04d7927 commit 3fe9ee6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 4 additions & 1 deletion be/src/runtime/buffer_control_block.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@ BufferControlBlock::BufferControlBlock(TUniqueId id, int buffer_size, RuntimeSta
}

BufferControlBlock::~BufferControlBlock() {
cancel(Status::Cancelled("Cancelled"));
cancel(Status::Cancelled(fmt::format(
"BufferControlBlock is destructed, this is not the expected path, the correct path is "
"ResultBufferMgr::cancel before the destructor, fragmentId: {}",
print_id(_fragment_id))));
}

Status BufferControlBlock::init() {
Expand Down
3 changes: 2 additions & 1 deletion be/src/runtime/result_buffer_mgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ void ResultBufferMgr::cancel_thread() {

// cancel query
for (const auto& id : query_to_cancel) {
cancel(id, Status::TimedOut("Query tiemout"));
cancel(id, Status::Cancelled(fmt::format(
"Clean up expired BufferControlBlock, queryId: {}", print_id(id))));
}
} while (!_stop_background_threads_latch.wait_for(std::chrono::seconds(1)));

Expand Down

0 comments on commit 3fe9ee6

Please sign in to comment.