ReplicaValidationForOpenConnectionAndInitCaches #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -898,7 +903,15 @@ private void validateReplicaAddresses(AddressInformation[] addresses) { | |||
| Arrays | |||
| .stream(addresses) | |||
| .map(address -> address.getPhysicalUri()) | |||
| .filter(addressUri -> addressUri.getHealthStatus() == Uri.HealthStatus.UnhealthyPending) | |||
| .filter(addressUri -> this.replicaValidationScopes.contains(addressUri.getHealthStatus())) | |||
| .sorted(new Comparator<Uri>() { | |||
There was a problem hiding this comment.
Just my 2 cents: I am not a fan of these stream-based or Linq-based operations liek sorted where it is unclear how the functional requirement is implemented.
Does sorted force using an ordered data structure? or use an unstructured data structure and then apply an order by after all results have been cached - like you would do when sorting the List you get back without this operator.
Perf-wise the latter would probably be better in this case>
Not blocking - and I don't have time to look into what .sorted actually is doing - just raising this as a general issue I have when these operators obfuscate the non-functional side-effects.
Add ServiceProvider Interface to azure-json and azure-xml
Prepare Core Libraries for September 2022 Release
…nostics (Azure#30639) * mapping of database account to number of clients * forgot to close object * added client map to client config tests * update to use dynamic number of clients as opposed to static since pipelines might affect * updated to use smoother syntax * update to use fluent api pattern * use entryset instead of keyset * use concurrent hashmap to ensure reads are consistent
Co-authored-by: Ben Broderick Phillips <[email protected]>
* replicaValidationBeforeUse Co-authored-by: annie-mac <[email protected]> Co-authored-by: annie-mac <[email protected]>
Use currentContext instead of ContextView
* ConnectionStateListener mark replica as unhealthy instead remove all addresses Co-authored-by: annie-mac <[email protected]> Co-authored-by: annie-mac <[email protected]>
xinlian12
pushed a commit
that referenced
this pull request
Apr 28, 2023
…BrokenConnections Proactive connection management for broken connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.