Removing Class.forName for implementation bridge helpers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Azure SDK Bot <[email protected]>
…nd CosmosException (Azure#28620) * Improved diagnostics with new models for StoreResponse, StoreResult and CosmosException * Fixed spot bugs related to storeResult.getException() * Updated query plan cache to ConcurrentHashMap with fixed size of 1000 to start with * Added exception response headers and message to direct and gateway errors. Also added code for throwing any java.lang.Error * Added unit tests for StoreReader and ConsistencyWriter * Disabled StoreReader unit test for error since it is causing other tests to fail. Will investigate later * Commented out the broken test * Reverted StoreReaderTest * Removed mockito-inline * Fixed StoreReaderTest static mocking * Fixed ConsistencyWriterTest static mocking * Code review comments and changelog addition * Fixed some test cases
xinlian12
reviewed
May 17, 2022
|
|
||
| public static void setCosmosClientBuilderAccessor(final CosmosClientBuilderAccessor newAccessor) { | ||
| if (accessor != null) { | ||
| throw new IllegalStateException("CosmosClientBuilder accessor already initialized!"); | ||
| if (!accessor.compareAndSet(null, newAccessor)) { |
There was a problem hiding this comment.
should we call doNothingButEnsureLoadingClass() in setter as well?
There was a problem hiding this comment.
No - because setXXX will always be called from the class that we want to ensure to be loaded.
|
Change log update? |
Added - although this PR is just to merge into your PR :-) |
… multiple times (Azure#28905) * ThroughputControl fix * add change log Co-authored-by: annie-mac <[email protected]>
…to users/fabianm/SetAccessorsFix
…to users/fabianm/SetAccessorsFix
…bianMeiswinkel/azure-sdk-for-java into users/fabianm/SetAccessorsFix
xinlian12
pushed a commit
that referenced
this pull request
Mar 31, 2023
* health insights sdk for java * rename country to countryOrRegion * update product name to azure-health-insights * update cspell with missing words * update root pom.xml and version_client.txt * update dependency versions * update dependency versions (#2) * skip jacoco * fix spell checks * Asaflevi/feature/healthinsights sdk for java (#3) * update dependency versions * skip jacoco * fix spell checks * skip jacoco * linting * remove redundant plugins * remove test.yaml files * remove redundant package.json file * fix sampes and readmes * spell * fix linting * fix sample repository reference * remove duplicate dependency (mockito) * alignment (readme) * fix readme title * setPlaybackSyncPollerPollInterval * update serviceversion class (emitter 0.5.1) * remove impressions png
xinlian12
pushed a commit
that referenced
this pull request
Apr 19, 2023
…BrokenConnections TestPR - NO REVIEW
xinlian12
pushed a commit
that referenced
this pull request
Feb 29, 2024
…property of AKV SecretClient (Azure#36603) * Allows configuration of disableChallengeResourceVerification property - Adds disableChallengeResourceVerification property to properties objects - Includes new property in mapping methods - Configures SecretClient in Factory when disableChallengeResourceVerification is set - Configures CertificateClient in Factory when disableChallengeResourceVerification is set - Updates/adds new tests - Updates Changelog Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> * Allows configuration of disableChallengeResourceVerification property - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> * Allows configuration of disableChallengeResourceVerification property - Fix a missed JavaDoc Signed-off-by: Esta Nagy <[email protected]> * Improve the configuration properties javadoc, and complete the additional-spring-configuration-metadata.json * Allows configuration of disableChallengeResourceVerification property - Code review fixes #3 - Simplifies factory method logic as per code review recommendation Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> --------- Signed-off-by: Esta Nagy <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Xiaolu Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.