Throughput control optimizations #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kushagraThapar
commented
Feb 11, 2021
kushagraThapar
commented
- Few optimizations, but not tested at all, please go through them and think if they make sense.
- Please criticize them and ask questions wherever you don't understand :)
kushagraThapar
changed the base branch from
master
to
ThroughputControl-Global
xinlian12
reviewed
Feb 11, 2021
| Schedulers.parallel().schedule(() -> this.refreshContainerMaxThroughputTask(this.cancellationTokenSource.getToken()).subscribe()); | ||
| }) | ||
| .thenReturn((T) this); | ||
| .then(this.createAndInitializeGroupControllers()) |
There was a problem hiding this comment.
but for then, "this.createAndInitializeGroupControllers" will still be executed right? The intention here is to only execute when the previous step succeeded?
xinlian12
pushed a commit
that referenced
this pull request
Feb 29, 2024
…property of AKV SecretClient (Azure#36603) * Allows configuration of disableChallengeResourceVerification property - Adds disableChallengeResourceVerification property to properties objects - Includes new property in mapping methods - Configures SecretClient in Factory when disableChallengeResourceVerification is set - Configures CertificateClient in Factory when disableChallengeResourceVerification is set - Updates/adds new tests - Updates Changelog Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> * Allows configuration of disableChallengeResourceVerification property - Code review fixes #1 - Renames disableChallengeResourceVerification to challengeResourceVerificationEnabled - Adds additional JavaDoc Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> * Allows configuration of disableChallengeResourceVerification property - Fix a missed JavaDoc Signed-off-by: Esta Nagy <[email protected]> * Improve the configuration properties javadoc, and complete the additional-spring-configuration-metadata.json * Allows configuration of disableChallengeResourceVerification property - Code review fixes #3 - Simplifies factory method logic as per code review recommendation Resolves Azure#36561 Signed-off-by: Esta Nagy <[email protected]> --------- Signed-off-by: Esta Nagy <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Xiaolu Dai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.