-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Make the IMAGE_NAME settable from env * Add Prow * Adapt for prow * test * Test 2 Signed-off-by: Dominique Vernier <[email protected]> * Change badge repo Signed-off-by: Dominique Vernier <[email protected]> * Fix some govet, gosimple issues Signed-off-by: Dominique Vernier <[email protected]> * Fix error message Signed-off-by: Dominique Vernier <[email protected]> * Run format Signed-off-by: Dominique Vernier <[email protected]>
- Loading branch information
1 parent
62d844a
commit 195bd8a
Showing
45 changed files
with
1,637 additions
and
1,147 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
<!-- START doctoc generated TOC please keep comment here to allow auto update --> | ||
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> | ||
**Table of Contents** *generated with [DocToc](https://github.com/thlorenz/doctoc)* | ||
|
||
- [Contributing guidelines](#contributing-guidelines) | ||
- [Sign the CLA](#sign-the-cla) | ||
- [Contributing A Patch](#contributing-a-patch) | ||
- [Issue and Pull Request Management](#issue-and-pull-request-management) | ||
- [Pre-check before submitting a PR](#pre-check-before-submitting-a-pr) | ||
- [Build and push images](#build-and-push-images) | ||
|
||
<!-- END doctoc generated TOC please keep comment here to allow auto update --> | ||
|
||
# Contributing guidelines | ||
|
||
## Sign the CLA | ||
|
||
IBM cloud projects require that you sign a Contributor License Agreement (CLA) before we can accept your pull requests. Please see xxx for more info | ||
|
||
## Contributing A Patch | ||
|
||
1. Submit an issue describing your proposed change to the repo in question. | ||
1. The [repo owners](OWNERS) will respond to your issue promptly. | ||
1. If your proposed change is accepted, and you haven't already done so, sign a Contributor License Agreement (see details above). | ||
1. Fork the desired repo, develop and test your code changes. | ||
1. Submit a pull request. | ||
|
||
## Issue and Pull Request Management | ||
|
||
Anyone may comment on issues and submit reviews for pull requests. However, in | ||
order to be assigned an issue or pull request, you must be a member of the | ||
[IBM](https://github.com/ibm) GitHub organization. | ||
|
||
Repo maintainers can assign you an issue or pull request by leaving a | ||
`/assign <your Github ID>` comment on the issue or pull request. | ||
|
||
## Pre-check before submitting a PR | ||
|
||
After your PR is ready to commit, please run following commands to check your code: | ||
|
||
```shell | ||
make check | ||
make test | ||
``` | ||
|
||
## Build and push images | ||
|
||
Make sure your code build passed: | ||
|
||
```shell | ||
export REGISTRY=<your-docker-registry> | ||
make build-push-images | ||
``` | ||
|
||
Now, you can follow the [getting started guide](./README.md#getting-started) to work with the xxx. |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.