forked from ProseMirror/prosemirror-view
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge from upstream #7
Open
shlroland
wants to merge
296
commits into
xheldon-prosemirror:pr
Choose a base branch
from
shlroland:master
base: pr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEATURE: Multiple `style` properties provided through the `attributes` prop are now merged.
FIX: Fix issue where recent Mobile Safari versions weren't treated as Mac platforms.
FIX: Fix an issue where some types of node decoration changes could cause an unnecessary cascade of node redraws. See https://discuss.prosemirror.net/t/node-decorations-before-custom-node-view-causes-rerender/3924
* add a destroy function to Decoration.widget * add documentation * add destroy to WidgetViewDesc
FEATURE: Widget decorations now accept a `destroy` option, which will be called when the widget is removed from the view. See https://discuss.prosemirror.net/t/unmounting-a-decoration-widget-created-with-react/3050
…artefacts FIX: When parsing clipboard content, ignore trailing BR nodes that look like they might be there as a contenteditable kludge. Issue ProseMirror/prosemirror#1218
Since apparently browsers natively keep those around even when not necessary. Issue ProseMirror/prosemirror#1218
FEATURE: `EditorView` now exposes an `isDestroyed` property that can be used to test if the view has been destroyed. See https://discuss.prosemirror.net/t/detect-if-a-view-has-been-destroyed/4180
FIX: Restore accidentally reduced lookahead distance in view updating algorithm. Co-authored-by: Sean Chamberlain <[email protected]>
…ks are present FIX: Avoid some unnecessary node redraws when marks are present in sibling nodes.
FIX: The clipboard parser will no longer drop trailing `<br>` nodes that appear in an inline parent element. Issue ProseMirror/prosemirror#1218
FIX: Improve the way the editor handles the mess of events produced when pressing Enter before a word that was just typed on Chrome + GBoard. Issue ProseMirror/prosemirror#1181
FIX: Fix an issue where compositions right before another instance of the composed text could cause the editor to crash. Issue ProseMirror/prosemirror#1226
…pdates FIX: Fix an issue where, if decorations changed during a pointer drag selection, the selection anchor might move around inappropriately. See https://discuss.prosemirror.net/t/selection-changes-when-inline-decoration-is-applied/1027/6
FIX: Fix a bug where reconfiguring node views caused the editor to lose focus. Closes ProseMirror/prosemirror#1236
FIX: Fix an issue where some commands didn't properly scroll the cursor into view on Mobile Safari. See https://discuss.prosemirror.net/t/scrollthreshold-scrollmargin-on-mobile-ios-for-list-items/6079
FIX: Fix a bug where starting a composition with stored marks or after a noninclusive mark, with an IME that keeps the cursor at the start of the composed text (like many Chinese IMEs) disrupted composition on Chrome. Closes ProseMirror/prosemirror#1450 Issue ProseMirror/prosemirror#1296
FIX: Fix a memory leak where a (single) destroyed editor could be kept alive through a reused `Range` object.
…ate the DOM FIX: Further improve preserving of compositions for IME systems that keep the cursor before the composed text.
FIX: When available, use `Selection.getComposedRanges` on Safari to find the selection inside a shadow DOM.
FIX: Fix a regression in composition handling in 1.33.3 that occurs for some IMEs when starting composition on an empty line. Closes ProseMirror/prosemirror#1458
FIX: Make sure the content slice stored for an in-editor drag is the one that was transformed by `transformCopied`.
FIX: Ignore stray `<br>` nodes added to parent list elements when backspacing near uneditable content in Firefox. Closes ProseMirror/prosemirror#1464
FIX: Fix a crash where the editor tried to call `removeAttribute` on a text node. Closes ProseMirror/prosemirror#1468
FIX: Fix an issue where coordinates near nested blocks could inappropriately be assigned to be inside those blocks. Closes ProseMirror/prosemirror#1466
FIX: When composition happens with the cursor between two text nodes, use the last mutated one to guess which one is being changed. See https://discuss.prosemirror.net/t/compositionend-not-fire-when-prosemirror-view-upgrade-to-1-33-3-and-above/6446
FIX: Fix an issue where dragging an image on Chrome versions before 121 failed to put the image file in the clipboard data. Closes ProseMirror/prosemirror#1472
FIX: Enable cross-site scripting protection hack when rendering nodes and marks inside the editor. See https://discuss.prosemirror.net/t/heads-up-xss-risk-in-domserializer/6572
… remains unchanged FIX: Prevent triple clicks and clicks on atom nodes from dispatching a selection update when the new selection is equal to the current selection. See https://discuss.prosemirror.net/t/trippleclick-empty-paragraph-cause-storedmarks-loss/6597
FIX: Don't crash when `window.getSelection()` returns null. Closes ProseMirror#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.