Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu version for worker nodes #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mavimo
Copy link
Collaborator

@mavimo mavimo commented Mar 29, 2020

Since:

  • we are now using Ubuntu 18.04 on new nodes that we create when a new cluster is created
  • we use Ubuntu 18.04 in test env
  • Ubuntu 18.04 is a LTS

I suggest to move the command that is used to add external worker to check for Ubuntu 18.04

@mavimo mavimo added the enhancement New feature or request label Mar 29, 2020
@mavimo mavimo added this to the 0.6 milestone Mar 29, 2020
@mavimo mavimo requested a review from xetys March 29, 2020 12:02
@mavimo mavimo self-assigned this Mar 29, 2020
issue, err := AppConf.SSHClient.RunCmd(externalNode, "cat /etc/issue | xargs")
if err != nil {
return err
}
if !strings.Contains(issue, "Ubuntu 16.04") {
return errors.New("target server has no Ubuntu 16.04 installed")
if !strings.Contains(issue, "Ubuntu 18.0404") {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me this had to be changed to "Ubuntu 18.04"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants