Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fsspec test due to fsspec upgrade #93

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix fsspec test due to fsspec upgrade #93

merged 1 commit into from
Sep 8, 2023

Conversation

seanses
Copy link
Contributor

@seanses seanses commented Sep 8, 2023 •
edited
Loading

fsspec upgrade in fsspec/filesystem_spec#1329 makes

  1. when using a trailing slash in globs, it returns only directories.
  2. the double asterisks ** matches 0+ directories.

This PR fix the tests accordingly.

port8080
port8080 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@port8080 port8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seanses seanses merged commit 579c35e into main Sep 8, 2023
3 checks passed
@seanses seanses deleted the di/fix-fsspec-test branch September 8, 2023 19:42
@seanses seanses mentioned this pull request Oct 11, 2023
Merged
seanses added a commit that referenced this pull request Oct 11, 2023
@seanses
sync xet-core and up fsspec (#103)
fd1a18a 
Up xet-core.
Also up fsspec version due to the fsspec upgrade and test changes in
#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@port8080 port8080 port8080 approved these changes

@ylow ylow Awaiting requested review from ylow

@hoytak hoytak Awaiting requested review from hoytak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanses @port8080