XEOK-93 Correctly remove AngleMeasurementsMouseControl and DistanceMe…

…asurementsMouseControl dot
xeokit · Aug 13, 2024 · f20cf28 · f20cf28
1 parent e6a6249
commit f20cf28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js b/src/plugins/AngleMeasurementsPlugin/AngleMeasurementsMouseControl.js
@@ -74,7 +74,6 @@ export class AngleMeasurementsMouseControl extends AngleMeasurementsControl {
 
     _initMarkerDiv() {
         const markerDiv = document.createElement('div');
-        markerDiv.setAttribute('id', 'myMarkerDiv');
         const canvas = this.scene.canvas.canvas;
         canvas.parentNode.insertBefore(markerDiv, canvas);
 
@@ -95,9 +94,8 @@ export class AngleMeasurementsMouseControl extends AngleMeasurementsControl {
 
     _destroyMarkerDiv() {
         if (this.markerDiv) {
-            const element = document.getElementById('myMarkerDiv')
-            element.parentNode.removeChild(element)
-            this.markerDiv = null
+            this.markerDiv.parentNode.removeChild(this.markerDiv);
+            this.markerDiv = null;
         }
     }
 

diff --git a/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js b/src/plugins/DistanceMeasurementsPlugin/DistanceMeasurementsMouseControl.js
@@ -82,7 +82,6 @@ export class DistanceMeasurementsMouseControl extends DistanceMeasurementsContro
 
     _initMarkerDiv() {
         const markerDiv = document.createElement('div');
-        markerDiv.setAttribute('id', 'myMarkerDiv');
         const canvas = this.scene.canvas.canvas;
         canvas.parentNode.insertBefore(markerDiv, canvas);
         markerDiv.style.background = "black";
@@ -102,9 +101,8 @@ export class DistanceMeasurementsMouseControl extends DistanceMeasurementsContro
 
     _destroyMarkerDiv() {
         if (this._markerDiv) {
-            const element = document.getElementById('myMarkerDiv')
-            element.parentNode.removeChild(element)
-            this._markerDiv = null
+            this._markerDiv.parentNode.removeChild(this._markerDiv);
+            this._markerDiv = null;
         }
     }