Small corrections to repo syncing and the behaviour of some gridview rows #3252
Conversation
… messages. Signed-off-by: Konstantina Chremmou <[email protected]>
- Removed call of virtual member Enabled in constructor. - Removed override of Enabled, because the method the setter called does nothing related to the row's enabled state. - Minor syntax updates. Signed-off-by: Konstantina Chremmou <[email protected]>
…ncWithCdnAction). Signed-off-by: Konstantina Chremmou <[email protected]>
| var syncAction = new SyncWithCdnAction(pool); | ||
| syncAction.Completed += a => | ||
| { | ||
| if (a.Succeeded) | ||
| CheckForCdnUpdates(a.Connection); | ||
| }; | ||
| return syncAction; |
There was a problem hiding this comment.
Is there an instance whereby we sync and not check for updates? Since we always run CheckForCdnUpdates after SyncWithCdnAction, should we just be adding CheckForCdnUpdatesAction in SyncWithCdnAction:Run, or is that a side effect?
Usually I'd be against having one action do two things, but I don't see why we'd run sync without the check afterwards, so it sort of is the same action.
There was a problem hiding this comment.
The only reason is that SyncWithCdnAction has to call CheckForCdnUpdates, not CheckForCdnUpdatesAction, and the former uses concepts (the Registry) which belong to XenAdmin, not XenModel, and it is not straight forward, if feasible, to move it because it blurrs the interface between business and UI logic (which is already not very clean in some areas).
danilo-delbusso
added
2 approvals
Please review each commit separately.