Ensure same variable name is used in WHERE clause as in SELECT/FROM #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vierbergenlars
force-pushed
the
fix-predicates-for-reserved-keywords
branch
from
ca5e3ab
to
b27a9e3
Compare
Most of the time, QueryDSL `PathBuilderFactory` uses the same variable name as in the generated `Q*` classes (which is used in select/from by spring-data-rest using the `EntityPathResolver`). However, this breaks down when an entity is used that would have a reserved keyword as simple name. In that case, the generated `Q*` class has a '1' appended to the variable (to avoid using a reserved keyword), but the `PathBuilderFactory` does not. (See querydsl/querydsl#1891 for the rationale). We must use the same strategy for naming our predicates as used by spring-data-rest to make this work, so a Thunx `PathBuilderFactory` interface is introduced, together with an implementation that creates a `PathBuilder` based on the metadata from the spring-data-rest `EntityPathResolver`.
vierbergenlars
force-pushed
the
fix-predicates-for-reserved-keywords
branch
from
b27a9e3
to
7d0ab60
Compare
tgeens
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time, QueryDSL
PathBuilderFactoryuses the same variablename as in the generated
Q*classes (which is used in select/from byspring-data-rest using the
EntityPathResolver). However, this breaksdown when an entity is used that would have a reserved keyword as simple
name.
In that case, the generated
Q*class has a '1' appended to thevariable (to avoid using a reserved keyword), but the
PathBuilderFactorydoes not. (Seequerydsl/querydsl#1891 for the rationale).
We must use the same strategy for naming our predicates as used by
spring-data-rest to make this work, so a Thunx
PathBuilderFactoryinterface is introduced, together with an implementation that creates a
PathBuilderbased on the metadata from the spring-data-restEntityPathResolver.