DPK-2958 Support V20201031 in Customer Object SDK #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityarx
reviewed
Aug 11, 2023
There was a problem hiding this comment.
If this is the default customer API version now, should we just keep the file name instead of renaming the file to account for the version?
There was a problem hiding this comment.
the default is the other one v20201031, let me rename that one
| @@ -19,7 +65,7 @@ export = class Customer { | |||
| referenceID: string; | |||
| mobileNumber?: string; | |||
| email?: string; | |||
| givenNames: string; | |||
| givenNames?: string; | |||
There was a problem hiding this comment.
shouldn't this field be mandatory?
There was a problem hiding this comment.
for v20200519, yes it's mandatory
but for v20201031, we don't have that field anymore, it will be under individualDetail
adityarx
approved these changes
Aug 11, 2023
sekaranglila
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? (You can share the JIRA Ticket here)
How? (Explain the Expected Outcome/Success criteria)
Testing?
Anything Else?