Add module with Http4s Blaze server #51
Draft
+159
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorath
commented
Oct 26, 2022
gregorath
force-pushed
the
http4s-backend
branch
from
9bade01
to
030a28c
Compare
jackcviers
requested changes
Oct 28, 2022
There was a problem hiding this comment.
So with the suggested changes, we can see that we're at least failing in the same way the other Async PRs are failing WRT cats-effect/loom integration. At least this test removes discipline law tests from the problem definition -- somehow, the fiber is not in the correct ownership context when fork is called.
I don't know why that may be the case yet. It will take some more debugging.
http4s-scala-fx/src/test/scala/http4s/fx/HttpServerFixtures.scala
Outdated
Show resolved
Hide resolved
http4s-scala-fx/src/test/scala/http4s/fx/HttpServerFixtures.scala
Outdated
Show resolved
Hide resolved
http4s-scala-fx/src/test/scala/http4s/fx/BlazeServerFXBackendSuite.scala
Outdated
Show resolved
Hide resolved
http4s-scala-fx/src/test/scala/http4s/fx/BlazeServerFXBackendSuite.scala
Outdated
Show resolved
Hide resolved
|
The comments have been addressed in 62cfea3 but as said this won't work until we have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #42 as we need the
Asyncinstance.an initial attempt to add the http4s backend server, currently blocked while waiting to see if we can make
Async.uncancelablework and use it.