Enable preview feature and update Java version #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
reviewed
Oct 19, 2022
.github/workflows/ci.yml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: Setup Scala | |||
| uses: olafurpg/setup-scala@v13 | |||
There was a problem hiding this comment.
We don't need this Github Action, and use the more commonly used actions/java-setup See olafurpg/setup-scala#49
Sbt 1.7.1 is pre-installed on ubuntu-latest, so we can simply use the setup-java action to install JDK 19.
Suggested change
| uses: olafurpg/setup-scala@v13 | |
| uses: actions/setup-[email protected] | |
| with: | |
| distribution: 'temurin' | |
| java-version: 19 |
It's not documented well yet on the actions/setup-java but the temurin Java 19 version is available for all platforms except Windows according to this issue. adoptium/adoptium#171
There was a problem hiding this comment.
Same applies to all other workflows that rely on setup-scala
|
Merged the commit with the flaky tests disabled, and green now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Java version after Java19 was released past month.