Fix launchers and completion injection #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Working on completion injection * Working on completion substitutiton
* Moves the frame builder to an external extension method on the transformedMethodSymbol * Adds typeExtensions to make making OrNull and OrTypes easier: ```scala someType | someOtherType =:= OrType(someType, someOtherType, true) someType.? =:= OrNull(someType) ``` * Fixes block application in Deferred launcher * moves some additional string names to the constants file
* Adds TransformedMethodKey and TransformedMethod to the * Uses putAttachment to attatch the transformed method to its subtrees to allow for local variable reconstruction in the transformation ContinuationsPhase companion * Constructs a Thicket around the original method rhs. Then collects the trees until a tree calling shift is encountered into a list of thickets, each ending in a call to shift. Finally, constructs the state machine match tree, creating a CaseDef for each thicket, then appends the final invocation error case. * Extracts IllegalArgumentException full name to constants * Extracts resumeBeforeInvoke message to constants
* Identifies the inlined calls to replace * TODO -- add initialization * TODO finish the safe resume transformation
* fixes bad denotation * TODO -- on 0 case, remove second part of iteration initialization and generated label.
* TODO: Check intermediate variable names * TODO: Handle ownership of nested trees
* TODO: Debug which option in the return value is not working * TODO: Replace suspension point values with reserved variables
* Makes the intermediate states return from the appropiate label * Replaces the raw values with continuation initialized value refs
* TODO: Fix unbound placeholder parameter
* Todo: Fix GenBCode (probably a non-entered symbol somewhere)
* Transformation is now fully done via TreeTypeMap with substitution * TODO values inside the anonymous function appear to be discarded -- figure out why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT TO BE MERGED -- DRAFT ONLY