Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: sum/effect font-size to inherited from fixed 20px #310

Closed
wants to merge 1 commit into from
Closed

fixed: sum/effect font-size to inherited from fixed 20px #310

wants to merge 1 commit into from

Conversation

neilcamilleri
Copy link

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Fixed font-size for sum/effect dice roll

  • What is the new behavior (if this is a feature change)?
    Font size inherited so it's scalable again

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@neilcamilleri
Copy link
Author

For some reason the whole css file was re-formatted with specifiers on multiple lines, but it did use the .prettierrc.yml in the repo to do so. Is it ok?

@xdy
Copy link
Owner

xdy commented Jan 9, 2021

Apparently I have a formatter war going on without realizing it as I seldom touch the css files.
For now I'll turn off prettier on css files (I don't like that it bloated the file by moving each class to a separate line), and revisit formating css in #311
So, I'll merge your part of the css file, but remove the reformatting. (Or, rather, I'll let intellij/eslint do whatever it does by default, but nothing beyond that.)
Thanks!

@xdy xdy closed this Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants