Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on create actor - untrained not created yet #1394

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Jul 4, 2023

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    error on create actor
    default characteristic for new skill is strength

  • What is the new behavior (if this is a feature change)?
    check to see if untrained exists
    set default characteristic for new skill as none

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@marvin9257 marvin9257 merged commit cc80a5f into xdy:master Jul 4, 2023
7 checks passed
@marvin9257 marvin9257 deleted the Error-on-create-actor branch July 4, 2023 15:10
github-actions bot pushed a commit that referenced this pull request Jul 4, 2023
## [3.2.5](v3.2.4...v3.2.5) (2023-07-04)

### Bug Fixes

* error on create actor - untrained not created yet ([#1394](#1394)) ([cc80a5f](cc80a5f))
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🎉 This PR is included in version 3.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant