[WIP] Experiments in e-graphs in IR #3113
Draft
+998
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…ng input example (#3185) This PR tries to address #3180 * Uncommented non-working examples (which require features from future PRs * Minimized the example for swapping inputs * Formatted the code --------- Co-authored-by: Jianyi Cheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
========================================
Coverage 90.20% 90.20%
========================================
Files 459 462 +3
Lines 57603 57912 +309
Branches 5559 5583 +24
========================================
+ Hits 51961 52241 +280
- Misses 4197 4216 +19
- Partials 1445 1455 +10 ☔ View full report in Codecov by Sentry. |
- [x] Add initial Python rewrite (for learning & documentation) - [ ] Add the corresponding PDL rewrite --------- Co-authored-by: Jianyi Cheng <[email protected]> Co-authored-by: Sasha Lopoukhine <[email protected]>
jianyicheng
reviewed
Nov 11, 2024
| ): | ||
| owner = xdsl_val.owner | ||
| assert isinstance(owner, eqsat.EClassOp) | ||
| assert ( |
There was a problem hiding this comment.
I guess this will no longer be true after the first rewrite, i.e. an eclass may have more than one operand?
|
Not sure if I am looking at the right PR but it seems there is no test on eqsatpdl... Is this expected? @superlopuh Happy to write one by myself if there isn't one. |
|
This is the everything PR, it would definitely be useful to add tests, but especially in the PRs that take bits of code from here that we think are ready and merge to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @tobiasgrosser @jianyicheng