Allow to parse types where attributes are expected (#415)

xdslproject · Feb 7, 2023 · eea6141 · eea6141
1 parent 30073f5
commit eea6141
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/tests/filecheck/mlir-conversion/builtin_attrs.mlir b/tests/filecheck/mlir-conversion/builtin_attrs.mlir
@@ -148,5 +148,16 @@
 
   // CHECK: dense_resource<resource_1> : tensor<1xi32>
 
+  "func.func"() ({}) {function_type = () -> (), 
+                      type_attr = index,
+                      sym_name = "memref"} : () -> ()
+
+  // CHECK: "type_attr" = index
+
+  "func.func"() ({}) {function_type = () -> (), 
+                      type_attr = !index,
+                      sym_name = "memref"} : () -> ()
+
+  // CHECK: "type_attr" = index
 
 }) : () -> ()
diff --git a/xdsl/parser.py b/xdsl/parser.py
@@ -1665,6 +1665,12 @@ def parse_attribute(self) -> Attribute:
 
             return value
 
+        # In MLIR, a type can be parsed at any attribute location.
+        # While MLIR wraps the type in a `TypeAttr`, we do not require this
+        # in xDSL.
+        if (type := self.try_parse_type()) is not None:
+            return type
+
         # If it isn't a dialect attr, parse builtin
         builtin_val = self.try_parse_builtin_attr()