dialects: (builtin) fix true/false printing (#3555)

We currently don't consistently print true and false for i1 values, this
PR fixes that in the cases I could find.

tests/filecheck/parser-printer/builtin_attrs.mlir

@@ -174,7 +174,7 @@
                       value1 = dense<[true, false]> : tensor<2xi1>,
                       sym_name = "dense_bool_attr"} : () -> ()
 
-  // CHECK: "value1" = dense<[1, 0]> : tensor<2xi1>
+  // CHECK: "value1" = dense<[true, false]> : tensor<2xi1>
 
   "func.func"() ({}) {function_type = () -> (),
                       value1 = opaque<"test", "contents">,

tests/irdl/test_declarative_assembly_format.py

@@ -2792,7 +2792,7 @@ class DefaultOp(IRDLOperation):
         ),
         (
             "test.default prop true opt_prop false",
-            "test.default prop 1 opt_prop 0",
+            "test.default prop true opt_prop false",
             '"test.default"() <{"prop" = true, "opt_prop" = false}> {"attr" = false} : () -> ()',
         ),
         (
@@ -2807,7 +2807,7 @@ class DefaultOp(IRDLOperation):
         ),
         (
             "test.default attr true opt_attr false",
-            "test.default attr 1 opt_attr 0",
+            "test.default attr true opt_attr false",
             '"test.default"() <{"prop" = false}> {"attr" = true, "opt_attr" = false} : () -> ()',
         ),
         (
@@ -2859,12 +2859,12 @@ class RenamedPropOp(IRDLOperation):
         ),
         (
             "test.renamed prop1 false prop2 false",
-            "test.renamed prop2 0",
+            "test.renamed prop2 false",
             '"test.renamed"() <{"test_prop1" = false, "test_prop2" = false}> : () -> ()',
         ),
         (
             "test.renamed prop1 true prop2 true",
-            "test.renamed prop1 1 prop2 1",
+            "test.renamed prop1 true prop2 true",
             '"test.renamed"() <{"test_prop1" = true, "test_prop2" = true}> : () -> ()',
         ),
     ],

xdsl/dialects/builtin.py

@@ -399,6 +399,15 @@ def verify_value(self, value: int):
     def bitwidth(self) -> int:
         return self.width.data
 
+    def print_value_without_type(self, value: int, printer: Printer):
+        """
+        Prints the value, printing `true` or `false` if self.width == 1.
+        """
+        if self.width.data == 1:
+            printer.print_string("true" if value else "false", indent=0)
+        else:
+            printer.print_string(f"{value}")
+
 
 i64 = IntegerType(64)
 i32 = IntegerType(32)
@@ -440,6 +449,12 @@ class LocationAttr(ParametrizedAttribute):
 class IndexType(ParametrizedAttribute):
     name = "index"
 
+    def print_value_without_type(self, value: int, printer: Printer):
+        """
+        Prints the value.
+        """
+        printer.print_string(f"{value}")
+
 
 IndexTypeConstr = BaseAttr(IndexType)
 
@@ -513,7 +528,7 @@ def parse_with_type(
         return IntegerAttr(parser.parse_integer(allow_boolean=(type == i1)), type)
 
     def print_without_type(self, printer: Printer):
-        return printer.print(self.value.data)
+        self.type.print_value_without_type(self.value.data, printer)
 
     def get_type(self) -> Attribute:
         return self.type
@@ -1896,7 +1911,7 @@ def parse_with_type(parser: AttrParser, type: Attribute) -> TypedAttribute:
     @staticmethod
     def _print_one_elem(val: Attribute, printer: Printer):
         if isinstance(val, IntegerAttr):
-            printer.print_string(f"{val.value.data}")
+            val.print_without_type(printer)
         elif isinstance(val, FloatAttr):
             printer.print_float(cast(AnyFloatAttr, val))
         else:

xdsl/printer.py

@@ -584,7 +584,7 @@ def print_attribute(self, attribute: Attribute) -> None:
             if attribute.elt_type == i1:
                 self.print_list(
                     data,
-                    lambda x: self.print_string("true" if x == 1 else "false"),
+                    lambda x: self.print_string("true" if x else "false"),
                 )
             else:
                 self.print_list(data, lambda x: self.print_string(f"{x}"))