-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (qft) initialise dialect #67
Open
kimxworrall
wants to merge
2
commits into
main
Choose a base branch
from
kim/qft/init
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,40 @@ | ||||||
from xdsl.dialects.builtin import IntAttr | ||||||
from xdsl.ir import Dialect | ||||||
from xdsl.irdl import irdl_attr_definition, ParameterDef | ||||||
from xdsl.parser import AttrParser | ||||||
from xdsl.printer import Printer | ||||||
|
||||||
from inconspiquous.gates import GateAttr | ||||||
|
||||||
|
||||||
@irdl_attr_definition | ||||||
class QFTAttr(GateAttr): | ||||||
name = "qft.n" | ||||||
|
||||||
num_qubits_param: ParameterDef[IntAttr] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Would this be simpler? |
||||||
|
||||||
@property | ||||||
def num_qubits(self) -> int: | ||||||
return self.num_qubits_param.data | ||||||
|
||||||
def __init__(self, num_qubits: int | IntAttr): | ||||||
if not isinstance(num_qubits, IntAttr): | ||||||
num_qubits = IntAttr(num_qubits) | ||||||
|
||||||
super().__init__((num_qubits,)) | ||||||
|
||||||
@classmethod | ||||||
def parse_parameters(cls, parser: AttrParser) -> tuple[IntAttr]: | ||||||
with parser.in_angle_brackets(): | ||||||
num_qubits = parser.parse_integer(allow_negative=False, allow_boolean=False) | ||||||
return (IntAttr.new(num_qubits),) | ||||||
|
||||||
def print_parameters(self, printer: Printer) -> None: | ||||||
return self.num_qubits_param.print_parameter(printer) | ||||||
|
||||||
|
||||||
QFT = Dialect( | ||||||
"qft", | ||||||
[], | ||||||
[QFTAttr], | ||||||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// RUN: QUOPT_ROUNDTRIP | ||
|
||
"test.op"() {gate = #qft.n<5>} : () -> () | ||
|
||
// CHECK: "test.op"() {gate = #qft.n<5>} : () -> () | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could have a test with a use of the gate to check that number of qubits is working correctly |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative to this would be to have an
algorithm
oralgo
dialect and putqft
inside. Do you see anything else being in this dialect?