-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Leaflet.markercluster #239
Conversation
…rather than upon number of markers. If an LMarker is flagged as in error state and it's included in a cluster, then the cluster's appearance will be changed based on the css style "cluster-nok", otherwise it will be displayed using the "cluster-ok" style.
Hello @AB-xdev , I'm sorry but I do not know how to fix these Sonar errors as it appears I must have a key that I do not have .. Any idea on how to fix that to give you a chance to review this PR ? |
The sonar workflow error likely comes from the missing token, that only we posses, we can check that manually when we review it later. |
Hi @AB-xdev any plan on merging the branch to main development branch ? |
I got a bit of time now to address #250. I'm not sure if we should add this feature since I don't know if many people will use it and it requires new JS libraries (that may not be needed by most users). I think it would be better if we provide this as a separate extension/maven package. I will clarify how we will go on here internally. |
We consolidated this topic into #307 Feel free to upvote #307 (comment) I'm closing this PR as we
|
From #307 (comment) (I think the comment was meant for here)
|
These changes add basic support for Leaflet.markercluster.
It enabled Markers clustering and adds an option to customize the cluster's color based on the state of the markers it contains (for example to show that at least one marker is in Error state).
It also adds the API needed to add Tooltips to the Markers.