Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Leaflet.markercluster #239

Closed
wants to merge 9 commits into from

Conversation

echarlus
Copy link
Contributor

These changes add basic support for Leaflet.markercluster.
It enabled Markers clustering and adds an option to customize the cluster's color based on the state of the markers it contains (for example to show that at least one marker is in Error state).
It also adds the API needed to add Tooltips to the Markers.

@echarlus
Copy link
Contributor Author

echarlus commented Jun 8, 2023

Hello @AB-xdev , I'm sorry but I do not know how to fix these Sonar errors as it appears I must have a key that I do not have .. Any idea on how to fix that to give you a chance to review this PR ?
Thanks

@AB-xdev AB-xdev mentioned this pull request Jul 7, 2023
@AB-xdev
Copy link
Member

AB-xdev commented Jul 7, 2023

@echarlus

The sonar workflow error likely comes from the missing token, that only we posses, we can check that manually when we review it later.

@echarlus
Copy link
Contributor Author

echarlus commented Sep 5, 2023

Hi @AB-xdev any plan on merging the branch to main development branch ?
Thanks.

@AB-xdev
Copy link
Member

AB-xdev commented Sep 7, 2023

@echarlus

I got a bit of time now to address #250.

I'm not sure if we should add this feature since I don't know if many people will use it and it requires new JS libraries (that may not be needed by most users).

I think it would be better if we provide this as a separate extension/maven package.

I will clarify how we will go on here internally.

@AB-xdev AB-xdev mentioned this pull request Dec 6, 2023
@AB-xdev
Copy link
Member

AB-xdev commented Dec 6, 2023

We consolidated this topic into #307

Feel free to upvote #307 (comment)


I'm closing this PR as we

  1. need to consider if there is enough demand for implementing this add-on
  2. the PR is no longer compatible with v4

@AB-xdev AB-xdev closed this Dec 6, 2023
@AB-xdev
Copy link
Member

AB-xdev commented Dec 6, 2023

From #307 (comment) (I think the comment was meant for here)

Hi @AB-xdev thanks for creating this new topic.
I'm still interested in having the merge done and I'm willing to make the changes to the P.R in order for them to work with the latest version.
Let me know when you've made your decision.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants