Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zipped zarr, where zarr is not visible in file path #9

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

konstntokas
Copy link
Collaborator

@konstntokas konstntokas commented Jan 15, 2025

Closes #4

Testing will be added in the next PR when I refactor the code to the new xcube's preload API.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.49%. Comparing base (2eb6f4f) to head (2e526ab).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
xcube_zenodo/preload.py 9.09% 10 Missing ⚠️
xcube_zenodo/_utils.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   41.21%   40.49%   -0.73%     
==========================================
  Files           7        7              
  Lines         313      326      +13     
==========================================
+ Hits          129      132       +3     
- Misses        184      194      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@konstntokas konstntokas force-pushed the konstntokas-004-handle_zipped_zarr branch from aaeab67 to 2e526ab Compare January 15, 2025 16:18
@konstntokas konstntokas marked this pull request as ready for review January 15, 2025 16:20
@konstntokas konstntokas requested a review from b-yogesh January 15, 2025 16:20
@konstntokas konstntokas merged commit 6c05c49 into main Jan 17, 2025
1 of 3 checks passed
@konstntokas konstntokas deleted the konstntokas-004-handle_zipped_zarr branch January 23, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle zipped zarrs without zarr suffix
2 participants