Implement open_data and support tiff, netcdf and zarr for s3 and https protocol
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start pr draft for documentation
work in progress notebooks work again backup unittest adjusted error in dependencies test re-recorded cassettes for test_open_data_abfs test adjusted xcube server STAC example to open geotiff and levels mldataset now supported data_type implemented simplified data opener
konstntokas
force-pushed
the
konstntokas-003-implement_open_data
branch
from
cbe7e87 to
14fc51b
Compare
|
This PR will be closed and shifted to PR #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
I suggest to start with the notebooks in the folder examples as an introduction.
Here, I encountered a problem with the levels file in the server demo in xcube. When I try to open the levels file, I get a mldataset instance back. Wen I then try to open one level, an error occurs in xcube_server_stac_s3.ipynb cell 12. I suspect that when starting the server, the
.levelsfile with Identifierlocalis used to calculatelocal_1win resample_in_time.py, which adds<dim>_bndsdata variables to thexr.Dataset, which in turn brings problems in levels. Any idea to mitigate that problem without changing the xcube server demo example?Further I changes the github action workflow so that the the current xcube repo is checked out. Furthermore, I run the xcube server to get a higher test coverage. The unit tests work with decorators and are only run if the server is running. So for the later development, the server can be easily turned of, if needed.
Filtering the asset is not implemented yet. It is documented in Issue #18. I see this as a nice add-on for later. Also the stac-spec of an asset requires only href.