Change data IDs and make the STAC data store searchable #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstntokas
force-pushed
the
konstntokas-013-change_data_id_url_part
branch
from
4769adb to
433a2a5
Compare
forman
requested changes
Jul 10, 2024
xcube_stac/store.py
Outdated
| ): | ||
| self._url = url | ||
| self._data_id_delimiter = data_id_delimiter | ||
| url_mod = url | ||
| if url_mod[-12:] == "catalog.json": |
There was a problem hiding this comment.
Avoid magic numbers. Instead put "catalog..json" in a constant, then use -len(_CATALOG_JSON).
xcube_stac/store.py
Outdated
Comment on lines
188
to
192
| metadata = dict( | ||
| bbox=item.bbox, | ||
| time_range=time_range | ||
| ) | ||
| return DatasetDescriptor(data_id, **metadata) |
xcube_stac/store.py
Outdated
Comment on lines
383
to
386
| DataStoreError( | ||
| "Either 'start_datetime' and 'end_datetime' or 'datetime' " | ||
| "needs to be determine in the STAC item." | ||
| ) |
There was a problem hiding this comment.
Make clear, it is not the user's fault, but an external problem.
xcube_stac/store.py
Outdated
| item object | ||
| """ | ||
| response = requests.request(method="GET", url=self._url_mod + data_id) | ||
| if response.status_code == 200: |
There was a problem hiding this comment.
Suggested change
| if response.status_code == 200: | |
| if response.ok: |
This is because 200 is not the only way to signal success. There are other success codes, that signal a cached result, etc.
forman
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Closes #13
data IDs
The data IDs are assigned to the the segment of the URL that follows the catalog's URL. This allows easy access to the item and read out of hrefs from the assets.
Make the STAC data store searchable
The search query parameters are given by STAC API Item Search. So far xcube-stac supports datetime, bbox, and collections.
If a catalog supports the item search conformance class, these query parameters are transferred to the server and the search is performed on the sever side. Otherwise, xcube-stac crawls through the catalog and selects the items where the search parameters are matched.
Note that the split between search and open data parameters is put on the item level. Search parameters are used to select items. Open parameters will be used to open the data. The parameter
asset_namestherefore is put to the open data parameters.