Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Add session control parsers #18

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

Mahad-10
Copy link
Member

No description provided.

@Mahad-10 Mahad-10 force-pushed the add-session-control-parsers branch from e1f7d7d to 0839b93 Compare June 11, 2024 14:26
Copy link
Member

@om26er om26er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change before merge

@@ -11,6 +11,7 @@ def __init__(self, msg: error_pb2.Error):
self._msg = msg
self._args = None
self._kwargs = None
self._unpack = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self._unpack = False
self._unpacked = False

@Mahad-10 Mahad-10 force-pushed the add-session-control-parsers branch from dcb38a2 to 5b179d0 Compare June 12, 2024 09:05
@Mahad-10 Mahad-10 merged commit 3982f61 into xconnio:main Jun 12, 2024
2 checks passed
@Mahad-10 Mahad-10 deleted the add-session-control-parsers branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants