Merge pull request #120 from muzzammilshahid/joiner-constructor

Make serializer and authenticator optional in Joiner constructor
xconnio · Jul 8, 2024 · 4df984b · 4df984b
2 parents 15a2444 + 9805a6f
commit 4df984b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/src/joiner.dart b/lib/src/joiner.dart
@@ -12,7 +12,7 @@ final clientRoles = <String, Map<String, Map>>{
 };
 
 class Joiner {
-  Joiner(this._realm, Serializer? serializer, IClientAuthenticator? authenticator)
+  Joiner(this._realm, {Serializer? serializer, IClientAuthenticator? authenticator})
       : _serializer = serializer ?? JSONSerializer(),
         _authenticator = authenticator ?? AnonymousAuthenticator("");
 

diff --git a/test/joiner_acceptor_test.dart b/test/joiner_acceptor_test.dart
@@ -36,7 +36,7 @@ void main() {
   var authenticator = Authenticator();
   test("AnonymousAuth", () {
     var serializer = JSONSerializer();
-    var joiner = Joiner(realm, serializer, AnonymousAuthenticator(""));
+    var joiner = Joiner(realm, serializer: serializer, authenticator: AnonymousAuthenticator(""));
     var acceptor = Acceptor(serializer: serializer, authenticator: authenticator);
 
     var hello = joiner.sendHello();
@@ -68,7 +68,7 @@ void main() {
 
 void testAuth(Authenticator authenticator, IClientAuthenticator clientAuthenticator) {
   var serializer = JSONSerializer();
-  var joiner = Joiner(realm, serializer, clientAuthenticator);
+  var joiner = Joiner(realm, serializer: serializer, authenticator: clientAuthenticator);
   var acceptor = Acceptor(serializer: serializer, authenticator: authenticator);
 
   var hello = joiner.sendHello();