[UPnP] Upgrade Platinum #1230
[UPnP] Upgrade Platinum #1230
Conversation
|
Ok i have adapted osx and ios xcode projects for a quick test. I can confirm that (once the xcode projects are synced) this compiles and works (tested a movie, a picture and a mp3) on osx and ios against my ushare server. Once you are ready to pull this, ping me and i will take care of the xcode sync. |
|
second attempt - all the build changes/class changes are squashed into 458dd72. I've tried to take all comments into consideration. Have ditched the changes to stack handling, and allowing non-MS clients to search. |
|
Do you still need help on the win side or did you receive the vs project files already? |
|
hi yeah if you could fix the win build that would be great - it should just On 26 August 2012 21:02, wsoltys [email protected] wrote:
|
|
You can find the fixes for the windows platform here: https://github.com/wsoltys/xbmc/commits/upgrade-platinum |
|
@alcoheca |
|
Right, should just hook up to vfs. NptXbmcFile.cpp just need to be extended |
|
@pieh have fixed the issue in d0c8f88 - thanks for spotting it. |
|
What's the feelings on getting this merged then? Any show-stoppers? |
|
is the no serving from remote a regression? |
|
fixed after doing stats via NPT_XbmcFile On 5 September 2012 13:22, Arne Morten Kvarving [email protected]:
|
|
Push the green button :-) |
|
Better make sure via IRC that someone is around for fixing the xcode projects - similar like here: |
|
I had merged @elupus 's xcode changes, but they need resynced to drop lib/libUPnP/Neptune/Source/System/Posix/NptPosixFile.cpp also need xcode changes for code-shuffle branch presuming that can go in - it's fairly benign WIN32 needs another round of changes for both branches and a pull request if possible. @wsoltys |
…e content length on HEAD requests' by elupus @ 9cbcf50
…browse req' by elupus @ cb110ea all other modifications to libPlatinum/Neptune since codiqs last commit have been checked and are not required / have been included upstream the following patches therefore do not need to be reinstated: 5e5156b 4df0a4c a6eaa58 964b08a 2f70d12 299d326 5bbf59f 370c836 755f17f 20c1ed6 0b11444 f96d966 99479c3 347aa55 a1993bf f13f20a 95df1d0 887728b 66d2daf ec70e26 296435b 99e0a1e 588a66a 3fd2548
…g comments & unused variable
…erving files from vfs was broken. Solution is to remove all filesystem access to Platinum and expand NPT_XbmcFile. Anything apart from GetInfo:: (stat) is ignored as Platinum only serves up library items, not file systems. Thanks to elupus for fix, and pieh for spotting this in the first place
|
Actually I've got the Xcode and Visual studio changes in fine, including the ones after the VFS fix. Focus on code-shuffle instead please.. :) this is good to go in, so hitting green after holding my breath for 10 seconds |
[gsoc] [UPnP] Upgrade Platinum
|
@elupus any reas on why you added SystemConfiguration.framework to the osx xcode project? Its red on my 10.6.8 installation (means not there) - and doesn't seem to be used. Beside that - are you able to sync XBMC-IOS and XBMC-ATV2 xcode projects aswell? |
|
mhh nvm already on it... |
|
@Memphiz it was used to get hostname of system. I suppose it could have been handled differently. |
|
@Memphiz no i don't think i did sync those. are they not part of the main project? |
|
No see XBMC-IOS.xcodeproj and XBMC-ATV2.xcodeproj. IOS done - now ATV2 :) |
|
thanks @Memphiz On 5 September 2012 19:17, Memphiz [email protected] wrote:
|
This upgrades Platinum to 0.6.9.1, reinstates any changes still needed that elupus made since the last upgrade, and cleans up a tiny bit of the xbmc code since some handling was simplified.
I don't have xcode or visual studio so those builds will need fixed too - sorry!