Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_probabilistic.py #340

Closed
wants to merge 2 commits into from
Closed

Conversation

aaronspring
Copy link
Collaborator

Description

allow float or int inputs

alternative solution: convert int and float inputs to xr with xr.ones_like(forecast) * observation

Closes #285

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • pytest

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas
  • Tests added for pytest, if necessary.

Pre-Merge Checklist (final steps)

  • I have rebased onto main or develop (wherever I am merging) and dealt with any conflicts.
  • I have squashed commits to a reasonable amount, and force-pushed the squashed commits.

References

Please add any references to manuscripts, textbooks, etc.

@pep8speaks
Copy link

pep8speaks commented Jul 26, 2021

Hello @aaronspring! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1074:1: W293 blank line contains whitespace

Comment last updated at 2021-07-26 07:33:56 UTC

@aaronspring aaronspring self-assigned this Jul 26, 2021
@aaronspring aaronspring added the bug Something isn't working label Jul 26, 2021
@aaronspring
Copy link
Collaborator Author

close in favor of #341

@aaronspring aaronspring deleted the AS_fix_Brier_float_inputs branch July 26, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem when calculating a baseline using a constant number
2 participants