Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simplecache instead of filecache #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keewis
Copy link
Contributor

@keewis keewis commented Aug 11, 2024

Options for different protocol layers are passed by the name of the protocol, so it should be simplecache instead of filecache.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Aug 11, 2024

😭 Deploy PR Preview 0d18c50 failed. Build logs

🤖 By surge-preview

@keewis
Copy link
Contributor Author

keewis commented Aug 11, 2024

I just saw that this is also mentioned in the review comments of the PR that added this section. Feel free to close this PR if you'd like to address that review comment in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant